To: vim_dev@googlegroups.com Subject: Patch 7.4.2256 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 7.4.2256 Problem: Coverity complains about null pointer check. Solution: Remove wrong and superfluous error check. Files: src/eval.c *** ../vim-7.4.2255/src/eval.c 2016-08-20 18:36:48.304969082 +0200 --- src/eval.c 2016-08-26 16:26:19.398687048 +0200 *************** *** 4941,4952 **** } *name = NUL; ! if (p == NUL) ! { ! EMSG2(_("E114: Missing quote: %s"), *arg); ! return FAIL; ! } ! *arg = p + 1; return OK; } --- 4941,4949 ---- } *name = NUL; ! if (*p != NUL) /* just in case */ ! ++p; ! *arg = p; return OK; } *** ../vim-7.4.2255/src/version.c 2016-08-26 15:51:45.284653063 +0200 --- src/version.c 2016-08-26 16:27:08.762255661 +0200 *************** *** 765,766 **** --- 765,768 ---- { /* Add new patch number below this line */ + /**/ + 2256, /**/ -- hundred-and-one symptoms of being an internet addict: 88. Every single time you press the 'Get mail' button...it does get new mail. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///