To: vim_dev@googlegroups.com Subject: Patch 7.4.1853 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 7.4.1853 Problem: Crash when job and channel are in the same dict while using partials. (Luc Hermitte) Solution: Do not decrement the channel reference count too early. Files: src/channel.c *** ../vim-7.4.1852/src/channel.c 2016-05-28 13:20:26.706660930 +0200 --- src/channel.c 2016-05-28 14:13:02.026617526 +0200 *************** *** 2566,2572 **** clear_tv(&rettv); channel_need_redraw = TRUE; } - --channel->ch_refcount; /* the callback is only called once */ vim_free(channel->ch_close_cb); --- 2566,2571 ---- *************** *** 2574,2579 **** --- 2573,2580 ---- partial_unref(channel->ch_close_partial); channel->ch_close_partial = NULL; + --channel->ch_refcount; + if (channel_need_redraw) { channel_need_redraw = FALSE; *** ../vim-7.4.1852/src/version.c 2016-05-28 13:40:06.586644700 +0200 --- src/version.c 2016-05-28 14:15:25.286615555 +0200 *************** *** 755,756 **** --- 755,758 ---- { /* Add new patch number below this line */ + /**/ + 1853, /**/ -- For a moment, nothing happened. Then, after a second or so, nothing continued to happen. -- Douglas Adams, "The Hitchhiker's Guide to the Galaxy" /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///