To: vim_dev@googlegroups.com Subject: Patch 7.4.1679 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 7.4.1679 Problem: Coverity: copying value of v_lock without initializing it. Solution: Init v_lock in rettv_list_alloc() and rettv_dict_alloc(). Files: src/eval.c *** ../vim-7.4.1678/src/eval.c 2016-03-28 19:27:09.951194772 +0200 --- src/eval.c 2016-03-28 22:25:28.590732917 +0200 *************** *** 6027,6032 **** --- 6027,6033 ---- rettv->vval.v_list = l; rettv->v_type = VAR_LIST; + rettv->v_lock = 0; ++l->lv_refcount; return OK; } *************** *** 7277,7282 **** --- 7278,7284 ---- rettv->vval.v_dict = d; rettv->v_type = VAR_DICT; + rettv->v_lock = 0; ++d->dv_refcount; return OK; } *** ../vim-7.4.1678/src/version.c 2016-03-28 22:17:12.143779546 +0200 --- src/version.c 2016-03-28 22:28:27.604913021 +0200 *************** *** 750,751 **** --- 750,753 ---- { /* Add new patch number below this line */ + /**/ + 1679, /**/ -- hundred-and-one symptoms of being an internet addict: 161. You get up before the sun rises to check your e-mail, and you find yourself in the very same chair long after the sun has set. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///